Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make form range track background more contrasted #39095

Merged
merged 2 commits into from Sep 13, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Aug 23, 2023

Description

This PR makes the form range track background color more contrasted for a11y reasons. The previous color wasn't enough contrasted, especially in light mode. I chose the secondary color instead of the tertiary color so that it works automatically in both light and dark modes.

Before

Screenshot 2023-08-23 at 07 43 19
Screenshot 2023-08-23 at 07 43 05

Now

Screenshot 2023-08-23 at 07 44 43
Screenshot 2023-08-23 at 07 44 33

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (N/A) My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #38999

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine on CSS side, I find it better on design side as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Range form element track background is practically invisible on a white background
3 participants