Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color mode: fix table state rendering #39033

Merged
merged 3 commits into from Sep 13, 2023
Merged

Color mode: fix table state rendering #39033

merged 3 commits into from Sep 13, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Aug 10, 2023 •
edited

Description

Changed the background states on dark mode.
Realigned the default table with the table dark, but this one might be reverted if needed. (d5110c9)

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #39029.

@louismaximepiton louismaximepiton requested a review from a team as a code owner August 10, 2023 14:12
@louismaximepiton louismaximepiton mentioned this pull request Aug 10, 2023
Closed
@julien-deramond julien-deramond mentioned this pull request Sep 11, 2023
Merged
@julien-deramond julien-deramond merged commit 86672f4 into main Sep 13, 2023
15 checks passed
@julien-deramond julien-deramond deleted the main-lmp-color-mode-table-fix branch September 13, 2023 06:17
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@louismaximepiton @romankupchak93
Fix table state rendering for color modes (twbs#39033)
dd786d4
@CGrabda CGrabda mentioned this pull request May 17, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 18, 2024
Open
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 19, 2024
Open
This was referenced May 19, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 19, 2024
Open
@Identian Identian mentioned this pull request May 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
color mode css v5
Projects
No open projects
v5.3.2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please adjust default table-striped color when dark mode is active
3 participants
@louismaximepiton @mdo @julien-deramond