fix(menu): resolve overflow issue with n-menu root-indent (#5616) #5618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kirklin
changed the title
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #5618 +/- ##
==========================================
- Coverage 61.07% 61.07% -0.01%
==========================================
Files 1107 1107
Lines 23619 23621 +2
Branches 6187 6188 +1
==========================================
+ Hits 14426 14427 +1
Misses 7598 7598
- Partials 1595 1596 +1 ☔ View full report in Codecov by Sentry. |
07akioni
reviewed
Jan 23, 2024
|
I think it's acceptable to keep current behavior, since if we change it, most menu's appearance would change. So I will revert link PR. |
|
Also, if someone would like to change overlay's position, a padding starts from edge would it easier to be customized. |
07akioni
added a commit
that referenced
this pull request
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adjusted the
paddingLeftRefcalculation logic to ensure proper left margin in different scenarios, addressing the issue of content overflow when setting a smaller root-indent in n-menu.Fixed the calculation of the
::beforepseudo-element's left position, adjusting its default value to match the design expectation and preventing content overflow.Related Issue
Fixes #5616