Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tsconfig/bases
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 69508e2c1ffe26aed6c413fabfd42e91166a4e85
Choose a base ref
...
head repository: tsconfig/bases
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: aebb59809e9302b5c9458aa6046d40ea784525d2
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on May 22, 2024

  1. [Ember]: set skipLibCheck: true

    NullVoxPopuli committed May 22, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    c4f5635 View commit details
  2. Merge pull request #269 from NullVoxPopuli/skipLibCheck-types-note-up…

    …date
    
    [Ember]: set skipLibCheck: true
    wagenet authored May 22, 2024
    Copy the full SHA
    aebb598 View commit details
Showing with 10 additions and 2 deletions.
  1. +10 −2 bases/ember.json
12 changes: 10 additions & 2 deletions bases/ember.json
Original file line number Diff line number Diff line change
@@ -24,6 +24,13 @@
// will likely improve over time
"allowJs": false,

// Practically, it is *nearly* impossible to have every type-checked
// package in your dependency graph to have compatible types.
// Good stewards of the ecosystem may opt to set this to false and try to
// fix packages with failures, but for most people, the error information
// is inactionable noise.
"skipLibCheck": true,

// --- TS for SemVer Types compatibility
// Strictness settings -- you should *not* change these: Ember code is not
// guaranteed to type check with these set to looser values.
@@ -76,8 +83,9 @@

// Don't implicitly pull in declarations from `@types` packages unless we
// actually import from them AND the package in question doesn't bring its
// own types. You may wish to override this e.g. with `"types": ["node"]`
// if your project has build-time elements that use NodeJS APIs.
// own types.
//
// You may wish to override this e.g. with `"types": ["ember-source/types"]`
"types": []
}
}