Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the best apporach for dealing with 3rd party failurers? #632

Open
maximveksler opened this issue Jan 14, 2024 · 1 comment
Open

Comments

@maximveksler
Copy link

I'm seeing terrascan failing, due to lack of support for a terraform feature I'm using. This causes trunk to report failure to run as well. What would be the suggest appraoch for dealing with the scenario where upstream has a known bug that is causing one of the plugins to fail?

I'd prefer trunk to understand that for 3rd praty plugin version X, it will fail on this fail and thus should be set to skip it up until the next version is released (after which resume scanning..)

Reference tenable/terrascan#1642 (comment)

@TylerJang27
Copy link
Collaborator

Hi @maximveksler! Thanks for flagging this. We don't have any mechanism for "temporarily skipping" linter runs like you've described, but there's a couple options I can recommend for you.

The most straightforward short-term fix would be to modify your .trunk/trunk.yaml to skip files that use the precondition syntax until the fix is released. You can read more about that syntax here, but an example would be:

lint:
  ignore:
    - linters: [terrascan]
       paths: [...] # glob paths supported

You also have the option of disabling terrascan entirely, or only for yourself locally in .trunk/user.yaml.

Let me know if that helps at all, happy to brainstorm other options that might work until a new fix is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants