Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when setting empty github-token #234

Closed
dorzepowski opened this issue Sep 22, 2023 · 0 comments · Fixed by #235
Closed

Warning when setting empty github-token #234

dorzepowski opened this issue Sep 22, 2023 · 0 comments · Fixed by #235

Comments

@dorzepowski
Copy link

Context

To trigger another workflow based on pushed tag with this action, the minimum option is to use Deploy Key.
But to fully leverage the Deploy Key, we need to prevent conventional-changelog-action from using worker Github Token.

To do so, I'm setting an empty string as github-token input.
This works, but running the action with empty string as github-token is raising the warning:

Warning: Can't add secret mask for empty string in ##[add-mask] command.

Expected result

  • Description of how to use Deploy Key should be extended with information that github-token must be set to empty string to trigger other workflows on push of tags.
  • Setting a github-token input as an empty string shouldn't raise a warning.
@dorzepowski dorzepowski changed the title Warning when unsetting github-token Warning when setting empty github-token Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant