Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for get requests #223

Open
msimmer opened this issue Nov 24, 2018 · 0 comments
Open

Add tests for get requests #223

msimmer opened this issue Nov 24, 2018 · 0 comments
Labels
b-ber/build/reader
Projects
b-ber/maintenance

Comments

@msimmer
Copy link
Member

msimmer commented Nov 24, 2018 •
edited

Expected Behavior

That there are tests that cover core features.

Actual Behavior

The XMLAdaptor class is used to load pages into the reader. This page loading behaviour has no tests.

Suggested Fix(es)

Add tests for get requests. We may also want to notify a user that the page can't be loaded. The testing suite is here
@msimmer msimmer added triage b-ber/build/reader needs testing An issue has been fixed, but requires testing by another human and removed triage labels Nov 24, 2018
@msimmer msimmer removed the needs testing An issue has been fixed, but requires testing by another human label Jun 24, 2019
@calebwaldorf calebwaldorf added keep and removed keep labels Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b-ber/build/reader
Projects
b-ber/maintenance
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calebwaldorf @msimmer