You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The parseXML in the DocumentPreProcessor class calls removeScriptElements, appendStyleSheets and appendScripts. Each of those methods should report errors should any be encountered. See here
Actual Behavior
Errors are not handled at all. The err variable is set to null and passed into callback.
Suggested Fix(es)
removeScriptElements, appendStyleSheets and appendScripts should be follow the callback pattern and report failure after each one is executed.
Expected Behavior
The
parseXML
in theDocumentPreProcessor
class callsremoveScriptElements
,appendStyleSheets
andappendScripts
. Each of those methods should report errors should any be encountered. See hereActual Behavior
Errors are not handled at all. The
err
variable is set tonull
and passed intocallback
.Suggested Fix(es)
removeScriptElements
,appendStyleSheets
andappendScripts
should be follow the callback pattern and report failure after each one is executed.The text was updated successfully, but these errors were encountered: