-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added header support for wiki tables #335
Added header support for wiki tables #335
Conversation
Thanks for the PR! Looks like this is failing some tests. Check the CI build :) |
Looking into it now. |
Empty cells must be completely surrounded by pipes
Okay, I believe I've followed all the steps for contributing a PR:
However, I'm not sure how to handle |
Nope no wiki update needed (yet?). I'll take a look at this early next week, thanks! |
I noticed you had to add |
Tables.text is under the "-knownfailure" flag, so it wasn't being tested prior to my change anyways. I ended up fixing it before realizing I should be running the tests with that flag so I don't have to fix a bunch of problems that aren't related to my change. However, that change still manages to get a test working, even if it's not tested by CI, so I decided to leave it in. |
Thank you and thanks for the clarification :) |
When do you want the Extras wiki updated? Now that the change is merged into master? Or after you push a new release to pypi? |
Any time works. I'm not totally sure if that wiki is up to date in general. If you want to take a stab at it, please do, thanks! |
Following the syntax used in Wikidot:
Also added indenting to match the format found when using the
tables
extra.