Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/aws-s3-multipart: empty the queue when pausing #4203

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 9, 2022

This is to avoid leaving aborted requests in the queue that would be reported as errors instead of being ignored.

This is to avoid leaving aborted requests in the queue that would
be reported as errors instead of being ignored.
@aduh95 aduh95 requested a review from Murderlon November 9, 2022 17:01
@aduh95 aduh95 merged commit 0375a49 into main Nov 9, 2022
@aduh95 aduh95 deleted the fix-pause-resume-multipart branch November 9, 2022 19:23
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
github-actions bot added a commit that referenced this pull request Nov 10, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/angular          |   0.5.0 | @uppy/image-editor     |   2.1.0 |
| @uppy/aws-s3-multipart |   3.1.0 | @uppy/locales          |   3.0.4 |
| @uppy/companion        |   4.1.0 | @uppy/tus              |   3.0.5 |
| @uppy/companion-client |   3.1.0 | @uppy/utils            |   5.1.0 |
| @uppy/dashboard        |   3.2.0 | uppy                   |   3.3.0 |

- @uppy/companion: change default S3 expiry from 300 to 800 seconds (Merlijn Vos / #4206)
- @uppy/dashboard: Single file mode (Artur Paikin / #4188)
- @uppy/locales: Fix UZ locale (Merlijn Vos / #4178)
- @uppy/utils: update typings for `RateLimitedQueue` (Antoine du Hamel / #4204)
- @uppy/aws-s3-multipart: empty the queue when pausing (Antoine du Hamel / #4203)
- @uppy/image-editor: add checkered background (Livia Medeiros / #4194)
- @uppy/aws-s3-multipart: refactor rate limiting approach (Antoine du Hamel / #4187)
- @uppy/companion: send expiry time along side S3 signed requests (Antoine du Hamel / #4202)
- @uppy/companion-client: add support for `AbortSignal` (Antoine du Hamel / #4201)
- @uppy/companion-client: prevent preflight race condition (Mikael Finstad / #4182)
- @uppy/aws-s3-multipart: change limit to 6 (Antoine du Hamel / #4199)
- @uppy/utils: add `cause` support for `AbortError`s (Antoine du Hamel / #4198)
- meta: Fix bad example for setFileState (Tim Whitney / #4191)
- meta: Update code example for getFiles (Tim Whitney / #4189)
- meta: Fix issue with outdated comment. (Tim Whitney / #4192)
- @uppy/aws-s3-multipart: remove unused `timeout` option (Antoine du Hamel / #4186)
- meta: Remove dollar sign from command for easier copy/pasting (Youssef Victor / #4180)
- @uppy/aws-s3-multipart,@uppy/tus: fix `Timed out waiting for socket` (Antoine du Hamel / #4177)
- meta: Add note about facebook approval (Mikael Finstad / #4172)
- meta: add a manual deploy for website (Antoine du Hamel / #4171)
Murderlon added a commit that referenced this pull request Dec 1, 2022

Verified

This commit was signed with the committer’s verified signature.
Murderlon Merlijn Vos
* main: (110 commits)
  @uppy/aws-s3-multipart: handle slow connections better (#4213)
  @uppy/companion-client: treat `*` the same as missing header (#4221)
  @uppy/utils: fix types (#4212)
  @uppy/companion: send expire info for non-multipart uploads (#4214)
  docs: fix `allowedMetaFields` documentation (#4216)
  meta: add more bundlers for automated testing (#4100)
  @uppy/aws-s3-multipart: Fix typo in url check (#4211)
  meta: use current version of packages when testing bundlers (#4208)
  meta: do not use the set-output command in workflows (#4175)
  Release: uppy@3.3.0 (#4207)
  Companion: change default S3 expiry from 300 to 800 seconds (#4206)
  Dashboard: Single file mode (#4188)
  Fix UZ locale (#4178)
  @uppy/utils: update typings for `RateLimitedQueue` (#4204)
  @uppy/aws-s3-multipart: empty the queue when pausing (#4203)
  image-editor: add checkered background (#4194)
  @uppy/aws-s3-multipart: refactor rate limiting approach (#4187)
  @uppy/companion: send expiry time along side S3 signed requests (#4202)
  @uppy/companion-client: add support for `AbortSignal` (#4201)
  @uppy/companion-client: prevent preflight race condition (#4182)
  ...
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/angular          |   0.5.0 | @uppy/image-editor     |   2.1.0 |
| @uppy/aws-s3-multipart |   3.1.0 | @uppy/locales          |   3.0.4 |
| @uppy/companion        |   4.1.0 | @uppy/tus              |   3.0.5 |
| @uppy/companion-client |   3.1.0 | @uppy/utils            |   5.1.0 |
| @uppy/dashboard        |   3.2.0 | uppy                   |   3.3.0 |

- @uppy/companion: change default S3 expiry from 300 to 800 seconds (Merlijn Vos / transloadit#4206)
- @uppy/dashboard: Single file mode (Artur Paikin / transloadit#4188)
- @uppy/locales: Fix UZ locale (Merlijn Vos / transloadit#4178)
- @uppy/utils: update typings for `RateLimitedQueue` (Antoine du Hamel / transloadit#4204)
- @uppy/aws-s3-multipart: empty the queue when pausing (Antoine du Hamel / transloadit#4203)
- @uppy/image-editor: add checkered background (Livia Medeiros / transloadit#4194)
- @uppy/aws-s3-multipart: refactor rate limiting approach (Antoine du Hamel / transloadit#4187)
- @uppy/companion: send expiry time along side S3 signed requests (Antoine du Hamel / transloadit#4202)
- @uppy/companion-client: add support for `AbortSignal` (Antoine du Hamel / transloadit#4201)
- @uppy/companion-client: prevent preflight race condition (Mikael Finstad / transloadit#4182)
- @uppy/aws-s3-multipart: change limit to 6 (Antoine du Hamel / transloadit#4199)
- @uppy/utils: add `cause` support for `AbortError`s (Antoine du Hamel / transloadit#4198)
- meta: Fix bad example for setFileState (Tim Whitney / transloadit#4191)
- meta: Update code example for getFiles (Tim Whitney / transloadit#4189)
- meta: Fix issue with outdated comment. (Tim Whitney / transloadit#4192)
- @uppy/aws-s3-multipart: remove unused `timeout` option (Antoine du Hamel / transloadit#4186)
- meta: Remove dollar sign from command for easier copy/pasting (Youssef Victor / transloadit#4180)
- @uppy/aws-s3-multipart,@uppy/tus: fix `Timed out waiting for socket` (Antoine du Hamel / transloadit#4177)
- meta: Add note about facebook approval (Mikael Finstad / transloadit#4172)
- meta: add a manual deploy for website (Antoine du Hamel / transloadit#4171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants