Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/angular: remove unnecessary console.log call #4139

Merged
merged 2 commits into from
Oct 13, 2022
Merged

@uppy/angular: remove unnecessary console.log call #4139

merged 2 commits into from
Oct 13, 2022
+0 −1

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 12, 2022

Fixes: #4138

@Murderlon
Copy link
Member

I kept this issue open for hacktoberfest people but I suppose we can solve it ourselves too.

CI is failing though:

[!] RollupError: Node tried to load your configuration file as CommonJS even though it is likely an ES module. To resolve this, change the extension of your configuration to ".mjs", set "type": "module" in your package.json file or pass the "--bundleConfigAsCjs" flag.

@aduh95
Merge branch 'main' into console-log-uninstalling

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f2dadc9
@aduh95 aduh95 merged commit 0a4ac6e into transloadit:main Oct 13, 2022
@aduh95 aduh95 deleted the console-log-uninstalling branch October 13, 2022 20:05
aduh95 added a commit that referenced this pull request Oct 19, 2022
@aduh95
@uppy/angular: remove unnecessary console.log call (#4139)
e9023f2 
Fixes: #4138
(cherry picked from commit 0a4ac6e)
@github-actions github-actions bot mentioned this pull request Oct 19, 2022
Merged
github-actions bot added a commit that referenced this pull request Oct 19, 2022
@github-actions
Release: uppy@2.13.7 (Maintenance) (#4156)
e2a7d0b 
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/angular          |   0.3.3 | @uppy/tus              |   2.4.5 |
| @uppy/aws-s3           |   2.2.3 | uppy                   |  2.13.7 |
| @uppy/golden-retriever |   2.1.3 |                        |         |

- @uppy/core: do not crash if a file is removed before the upload starts (Antoine du Hamel / #4148)
- @uppy/xhr-upload: fix `Timed out waiting for socket` (Antoine du Hamel / #4150)
- @uppy/golden-retriever: Fix retry upload with Golden Retriever (Merlijn Vos / #4155)
- @uppy/aws-s3: fix `Cannot mark a queued request as done` in `MiniXHRUpload` (Antoine du Hamel / #4151)
- @uppy/angular: remove unnecessary `console.log` call (Antoine du Hamel / #4139)
@github-actions github-actions bot mentioned this pull request Oct 19, 2022
Merged
aduh95 added a commit that referenced this pull request Oct 19, 2022
@github-actions @aduh95
Release: uppy@3.2.0 (#4157)
d25149d 
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/angular          |   0.4.3 | @uppy/tus              |   3.0.3 |
| @uppy/aws-s3           |   3.0.3 | @uppy/url              |   3.1.0 |
| @uppy/companion        |   4.0.4 | @uppy/webcam           |   3.2.1 |
| @uppy/core             |   3.0.3 | @uppy/xhr-upload       |   3.0.3 |
| @uppy/golden-retriever |   3.0.2 | uppy                   |   3.2.0 |
| @uppy/locales          |   3.0.2 |                        |         |

- @uppy/webcam: fix bug when Dashboard is using a custom id (Antoine du Hamel / #4099)
- @uppy/url: refactor `UrlUI` (Antoine du Hamel / #4143)
- @uppy/url: trim whitespace around user input (Andrew McIntee / #4143)
- @uppy/core: do not crash if a file is removed before the upload starts (Antoine du Hamel / #4148)
- @uppy/xhr-upload: fix `Timed out waiting for socket` (Antoine du Hamel / #4150)
- @uppy/golden-retriever: Fix retry upload with Golden Retriever (Merlijn Vos / #4155)
- @uppy/aws-s3,@uppy/xhr-upload: fix `Cannot mark a queued request as done` in `MiniXHRUpload` (Antoine du Hamel / #4151)
- meta: add a CI check to validate `yarn.lock` (Antoine du Hamel / #4154)
- meta: fix outdated `yarn.lock` (Antoine du Hamel / #4153)
- meta: fix `transloadit-xhr` dev example (Antoine du Hamel / #4149)
- meta: Add example for Uppy with S3 and a Node.js server (Raúl Ibáñez / #4129)
- @uppy/locales: Fix duplicate keys in UK_UA.js (Murderlon)
- @uppy/companion: add workaround for S3 accelerated endpoints (Mikael Finstad / #4140)
- @uppy/locales: Add missing Ukrainian locale entries (Andrii Bodnar / #4145)
- @uppy/angular: remove unnecessary `console.log` call (Antoine du Hamel / #4139)
- meta: fix bundlers workflow (Antoine du Hamel / #4144)
- meta: fix default sources (Mikael Finstad / #4134)
- @uppy/locales: Update pl_PL.js (Daniel Kamiński / #4136)
- @uppy/core: Fix Uppy.cancelAll and Uppy.close types (Sven Grunewaldt / #4128)
- @uppy/companion: fix error message (Mikael Finstad / #4125)
- @uppy/xhr-upload: queue requests for socket token for remote files (Daniel Jones / #4123)

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 added a commit that referenced this pull request Oct 19, 2022
@github-actions @aduh95
Release: uppy@3.2.0 (#4157)
4219cf4 
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/angular          |   0.4.3 | @uppy/tus              |   3.0.3 |
| @uppy/aws-s3           |   3.0.3 | @uppy/url              |   3.1.0 |
| @uppy/companion        |   4.0.4 | @uppy/webcam           |   3.2.1 |
| @uppy/core             |   3.0.3 | @uppy/xhr-upload       |   3.0.3 |
| @uppy/golden-retriever |   3.0.2 | uppy                   |   3.2.0 |
| @uppy/locales          |   3.0.2 |                        |         |

- @uppy/webcam: fix bug when Dashboard is using a custom id (Antoine du Hamel / #4099)
- @uppy/url: refactor `UrlUI` (Antoine du Hamel / #4143)
- @uppy/url: trim whitespace around user input (Andrew McIntee / #4143)
- @uppy/core: do not crash if a file is removed before the upload starts (Antoine du Hamel / #4148)
- @uppy/xhr-upload: fix `Timed out waiting for socket` (Antoine du Hamel / #4150)
- @uppy/golden-retriever: Fix retry upload with Golden Retriever (Merlijn Vos / #4155)
- @uppy/aws-s3,@uppy/xhr-upload: fix `Cannot mark a queued request as done` in `MiniXHRUpload` (Antoine du Hamel / #4151)
- meta: add a CI check to validate `yarn.lock` (Antoine du Hamel / #4154)
- meta: fix outdated `yarn.lock` (Antoine du Hamel / #4153)
- meta: fix `transloadit-xhr` dev example (Antoine du Hamel / #4149)
- meta: Add example for Uppy with S3 and a Node.js server (Raúl Ibáñez / #4129)
- @uppy/locales: Fix duplicate keys in UK_UA.js (Murderlon)
- @uppy/companion: add workaround for S3 accelerated endpoints (Mikael Finstad / #4140)
- @uppy/locales: Add missing Ukrainian locale entries (Andrii Bodnar / #4145)
- @uppy/angular: remove unnecessary `console.log` call (Antoine du Hamel / #4139)
- meta: fix bundlers workflow (Antoine du Hamel / #4144)
- meta: fix default sources (Mikael Finstad / #4134)
- @uppy/locales: Update pl_PL.js (Daniel Kamiński / #4136)
- @uppy/core: Fix Uppy.cancelAll and Uppy.close types (Sven Grunewaldt / #4128)
- @uppy/companion: fix error message (Mikael Finstad / #4125)
- @uppy/xhr-upload: queue requests for socket token for remote files (Daniel Jones / #4123)

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
@github-actions @aduh95
Release: uppy@3.2.0 (transloadit#4157)
bf31b88 
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/angular          |   0.4.3 | @uppy/tus              |   3.0.3 |
| @uppy/aws-s3           |   3.0.3 | @uppy/url              |   3.1.0 |
| @uppy/companion        |   4.0.4 | @uppy/webcam           |   3.2.1 |
| @uppy/core             |   3.0.3 | @uppy/xhr-upload       |   3.0.3 |
| @uppy/golden-retriever |   3.0.2 | uppy                   |   3.2.0 |
| @uppy/locales          |   3.0.2 |                        |         |

- @uppy/webcam: fix bug when Dashboard is using a custom id (Antoine du Hamel / transloadit#4099)
- @uppy/url: refactor `UrlUI` (Antoine du Hamel / transloadit#4143)
- @uppy/url: trim whitespace around user input (Andrew McIntee / transloadit#4143)
- @uppy/core: do not crash if a file is removed before the upload starts (Antoine du Hamel / transloadit#4148)
- @uppy/xhr-upload: fix `Timed out waiting for socket` (Antoine du Hamel / transloadit#4150)
- @uppy/golden-retriever: Fix retry upload with Golden Retriever (Merlijn Vos / transloadit#4155)
- @uppy/aws-s3,@uppy/xhr-upload: fix `Cannot mark a queued request as done` in `MiniXHRUpload` (Antoine du Hamel / transloadit#4151)
- meta: add a CI check to validate `yarn.lock` (Antoine du Hamel / transloadit#4154)
- meta: fix outdated `yarn.lock` (Antoine du Hamel / transloadit#4153)
- meta: fix `transloadit-xhr` dev example (Antoine du Hamel / transloadit#4149)
- meta: Add example for Uppy with S3 and a Node.js server (Raúl Ibáñez / transloadit#4129)
- @uppy/locales: Fix duplicate keys in UK_UA.js (Murderlon)
- @uppy/companion: add workaround for S3 accelerated endpoints (Mikael Finstad / transloadit#4140)
- @uppy/locales: Add missing Ukrainian locale entries (Andrii Bodnar / transloadit#4145)
- @uppy/angular: remove unnecessary `console.log` call (Antoine du Hamel / transloadit#4139)
- meta: fix bundlers workflow (Antoine du Hamel / transloadit#4144)
- meta: fix default sources (Mikael Finstad / transloadit#4134)
- @uppy/locales: Update pl_PL.js (Daniel Kamiński / transloadit#4136)
- @uppy/core: Fix Uppy.cancelAll and Uppy.close types (Sven Grunewaldt / transloadit#4128)
- @uppy/companion: fix error message (Mikael Finstad / transloadit#4125)
- @uppy/xhr-upload: queue requests for socket token for remote files (Daniel Jones / transloadit#4123)

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Murderlon Murderlon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular package remove "Uninstalling..." message
2 participants
@aduh95 @Murderlon