Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Uppy.cancelAll and Uppy.close types #4128

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

strayer
Copy link
Contributor

@strayer strayer commented Sep 29, 2022

Closes #4126

Note: I was unable to get my fork working in the project where I discovered the issue, but the change seems simple enough… any tips how I could verify this locally would be appreciated.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@Murderlon Murderlon merged commit 930645e into transloadit:main Sep 30, 2022
@github-actions github-actions bot mentioned this pull request Oct 19, 2022
aduh95 added a commit that referenced this pull request Oct 19, 2022
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/angular          |   0.4.3 | @uppy/tus              |   3.0.3 |
| @uppy/aws-s3           |   3.0.3 | @uppy/url              |   3.1.0 |
| @uppy/companion        |   4.0.4 | @uppy/webcam           |   3.2.1 |
| @uppy/core             |   3.0.3 | @uppy/xhr-upload       |   3.0.3 |
| @uppy/golden-retriever |   3.0.2 | uppy                   |   3.2.0 |
| @uppy/locales          |   3.0.2 |                        |         |

- @uppy/webcam: fix bug when Dashboard is using a custom id (Antoine du Hamel / #4099)
- @uppy/url: refactor `UrlUI` (Antoine du Hamel / #4143)
- @uppy/url: trim whitespace around user input (Andrew McIntee / #4143)
- @uppy/core: do not crash if a file is removed before the upload starts (Antoine du Hamel / #4148)
- @uppy/xhr-upload: fix `Timed out waiting for socket` (Antoine du Hamel / #4150)
- @uppy/golden-retriever: Fix retry upload with Golden Retriever (Merlijn Vos / #4155)
- @uppy/aws-s3,@uppy/xhr-upload: fix `Cannot mark a queued request as done` in `MiniXHRUpload` (Antoine du Hamel / #4151)
- meta: add a CI check to validate `yarn.lock` (Antoine du Hamel / #4154)
- meta: fix outdated `yarn.lock` (Antoine du Hamel / #4153)
- meta: fix `transloadit-xhr` dev example (Antoine du Hamel / #4149)
- meta: Add example for Uppy with S3 and a Node.js server (Raúl Ibáñez / #4129)
- @uppy/locales: Fix duplicate keys in UK_UA.js (Murderlon)
- @uppy/companion: add workaround for S3 accelerated endpoints (Mikael Finstad / #4140)
- @uppy/locales: Add missing Ukrainian locale entries (Andrii Bodnar / #4145)
- @uppy/angular: remove unnecessary `console.log` call (Antoine du Hamel / #4139)
- meta: fix bundlers workflow (Antoine du Hamel / #4144)
- meta: fix default sources (Mikael Finstad / #4134)
- @uppy/locales: Update pl_PL.js (Daniel Kamiński / #4136)
- @uppy/core: Fix Uppy.cancelAll and Uppy.close types (Sven Grunewaldt / #4128)
- @uppy/companion: fix error message (Mikael Finstad / #4125)
- @uppy/xhr-upload: queue requests for socket token for remote files (Daniel Jones / #4123)

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 added a commit that referenced this pull request Oct 19, 2022
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/angular          |   0.4.3 | @uppy/tus              |   3.0.3 |
| @uppy/aws-s3           |   3.0.3 | @uppy/url              |   3.1.0 |
| @uppy/companion        |   4.0.4 | @uppy/webcam           |   3.2.1 |
| @uppy/core             |   3.0.3 | @uppy/xhr-upload       |   3.0.3 |
| @uppy/golden-retriever |   3.0.2 | uppy                   |   3.2.0 |
| @uppy/locales          |   3.0.2 |                        |         |

- @uppy/webcam: fix bug when Dashboard is using a custom id (Antoine du Hamel / #4099)
- @uppy/url: refactor `UrlUI` (Antoine du Hamel / #4143)
- @uppy/url: trim whitespace around user input (Andrew McIntee / #4143)
- @uppy/core: do not crash if a file is removed before the upload starts (Antoine du Hamel / #4148)
- @uppy/xhr-upload: fix `Timed out waiting for socket` (Antoine du Hamel / #4150)
- @uppy/golden-retriever: Fix retry upload with Golden Retriever (Merlijn Vos / #4155)
- @uppy/aws-s3,@uppy/xhr-upload: fix `Cannot mark a queued request as done` in `MiniXHRUpload` (Antoine du Hamel / #4151)
- meta: add a CI check to validate `yarn.lock` (Antoine du Hamel / #4154)
- meta: fix outdated `yarn.lock` (Antoine du Hamel / #4153)
- meta: fix `transloadit-xhr` dev example (Antoine du Hamel / #4149)
- meta: Add example for Uppy with S3 and a Node.js server (Raúl Ibáñez / #4129)
- @uppy/locales: Fix duplicate keys in UK_UA.js (Murderlon)
- @uppy/companion: add workaround for S3 accelerated endpoints (Mikael Finstad / #4140)
- @uppy/locales: Add missing Ukrainian locale entries (Andrii Bodnar / #4145)
- @uppy/angular: remove unnecessary `console.log` call (Antoine du Hamel / #4139)
- meta: fix bundlers workflow (Antoine du Hamel / #4144)
- meta: fix default sources (Mikael Finstad / #4134)
- @uppy/locales: Update pl_PL.js (Daniel Kamiński / #4136)
- @uppy/core: Fix Uppy.cancelAll and Uppy.close types (Sven Grunewaldt / #4128)
- @uppy/companion: fix error message (Mikael Finstad / #4125)
- @uppy/xhr-upload: queue requests for socket token for remote files (Daniel Jones / #4123)

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/angular          |   0.4.3 | @uppy/tus              |   3.0.3 |
| @uppy/aws-s3           |   3.0.3 | @uppy/url              |   3.1.0 |
| @uppy/companion        |   4.0.4 | @uppy/webcam           |   3.2.1 |
| @uppy/core             |   3.0.3 | @uppy/xhr-upload       |   3.0.3 |
| @uppy/golden-retriever |   3.0.2 | uppy                   |   3.2.0 |
| @uppy/locales          |   3.0.2 |                        |         |

- @uppy/webcam: fix bug when Dashboard is using a custom id (Antoine du Hamel / transloadit#4099)
- @uppy/url: refactor `UrlUI` (Antoine du Hamel / transloadit#4143)
- @uppy/url: trim whitespace around user input (Andrew McIntee / transloadit#4143)
- @uppy/core: do not crash if a file is removed before the upload starts (Antoine du Hamel / transloadit#4148)
- @uppy/xhr-upload: fix `Timed out waiting for socket` (Antoine du Hamel / transloadit#4150)
- @uppy/golden-retriever: Fix retry upload with Golden Retriever (Merlijn Vos / transloadit#4155)
- @uppy/aws-s3,@uppy/xhr-upload: fix `Cannot mark a queued request as done` in `MiniXHRUpload` (Antoine du Hamel / transloadit#4151)
- meta: add a CI check to validate `yarn.lock` (Antoine du Hamel / transloadit#4154)
- meta: fix outdated `yarn.lock` (Antoine du Hamel / transloadit#4153)
- meta: fix `transloadit-xhr` dev example (Antoine du Hamel / transloadit#4149)
- meta: Add example for Uppy with S3 and a Node.js server (Raúl Ibáñez / transloadit#4129)
- @uppy/locales: Fix duplicate keys in UK_UA.js (Murderlon)
- @uppy/companion: add workaround for S3 accelerated endpoints (Mikael Finstad / transloadit#4140)
- @uppy/locales: Add missing Ukrainian locale entries (Andrii Bodnar / transloadit#4145)
- @uppy/angular: remove unnecessary `console.log` call (Antoine du Hamel / transloadit#4139)
- meta: fix bundlers workflow (Antoine du Hamel / transloadit#4144)
- meta: fix default sources (Mikael Finstad / transloadit#4134)
- @uppy/locales: Update pl_PL.js (Daniel Kamiński / transloadit#4136)
- @uppy/core: Fix Uppy.cancelAll and Uppy.close types (Sven Grunewaldt / transloadit#4128)
- @uppy/companion: fix error message (Mikael Finstad / transloadit#4125)
- @uppy/xhr-upload: queue requests for socket token for remote files (Daniel Jones / transloadit#4123)

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript type of Uppy.close is incorrect
2 participants