@uppy/dashboard: add dashboard:show-panel event

[jsanchez034]

This change adds a new event to the Uppy Dashboard component called 'dashboard:show-panel' so that consumers of the component can detect when a provider is selected in the Dashboard component. See #4081 for more details.

On a side noteI attempted to run corepack yarn run test:unit locally but got some odd errors around parts of the code I had not modified....

I'm running the tests with node 16.17.0 locally and followed the contributing guides.

[Murderlon]

Thanks :)

[Murderlon]

On a side noteI attempted to run corepack yarn run test:unit locally but got some odd errors around parts of the code I had not modified....

I'm not sure what is going on here as the tests in CI do run successfully 🤔

[jsanchez034]

On a side noteI attempted to run corepack yarn run test:unit locally but got some odd errors around parts of the code I had not modified....

I'm not sure what is going on here as the tests in CI do run successfully 🤔

Yeah not sure whats going on either. I use nodenv to manage different versions of node on my local machine. I wonder if that has something to do with it

[jsanchez034]

On a side noteI attempted to run corepack yarn run test:unit locally but got some odd errors around parts of the code I had not modified....

I'm not sure what is going on here as the tests in CI do run successfully 🤔

Yeah not sure whats going on either. I use nodenv to manage different versions of node on my local machine. I wonder if that has something to do with it

I think I narrowed it down to these lines being transpiled incorrectly on my machine...

uppy/packages/@uppy/core/src/Uppy.js

Lines 1405 to 1409 in 2b4b6b9

	const steps = [
	...this.#preProcessors,
	...this.#uploaders,
	...this.#postProcessors,
	]

If this.#preProcessors, this.#uploaders or this.#postProcessors are an empty Set, then the resulting steps const looks like the following when console logged ( #preProcessors and #postProcessors are empty in the following example ) ...

[ Set(0) {}, Set(1) { [Function (anonymous)] }, Set(0) {} ]

[jsanchez034]

On a side noteI attempted to run corepack yarn run test:unit locally but got some odd errors around parts of the code I had not modified....

I'm not sure what is going on here as the tests in CI do run successfully 🤔

Yeah not sure whats going on either. I use nodenv to manage different versions of node on my local machine. I wonder if that has something to do with it

I think I narrowed it down to these lines being transpiled incorrectly on my machine...

uppy/packages/@uppy/core/src/Uppy.js

Lines 1405 to 1409 in 2b4b6b9

	const steps = [
	...this.#preProcessors,
	...this.#uploaders,
	...this.#postProcessors,
	]

If this.#preProcessors, this.#uploaders or this.#postProcessors are an empty Set, then the resulting steps const looks like the following when console logged ( #preProcessors and #postProcessors are empty in the following example ) ...

[ Set(0) {}, Set(1) { [Function (anonymous)] }, Set(0) {} ]

Found this in the babel babel-plugin-transform-spread docs...
https://babeljs.io/docs/en/babel-plugin-transform-spread#loose

Tested setting loose to false here in the babel config ...

uppy/babel.config.js

Line 15 in 2b4b6b9

loose: true,

And the unit tests pass for me. Odd that tests pass in CI without this babel config change 🤔

[jsanchez034]

Oh one last thing that fixed the issue for me is setting the NODE_ENV to test...

NODE_ENV=test corepack yarn run test:unit

This allowed the tests to pass without needing to modify the babel config 😄

[Murderlon]

Thanks!

[jsanchez034]

Thanks!

Thank you @Murderlon! Do you know when the next release of @uppy/dashboard would be?

[Murderlon]

Not a schedule for it at the moment but I think we wanted to do a bug fix release soon so then it will be part of it