Bug fix for the #filing_version logic
#294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assuming the first subfield in a field would hold content (e.g., `$a`) and thus failed when it held a pointer to a linking field (e.g., `$6 245-01`) Fixed the code, added a test, changed CHANGES.md and upped the patch version.
|
The 9.1 failure is something about the CI environment. See jruby/jruby#4834 -- it was fixed in later versions. |
billdueber
force-pushed
the
filing_version_alphabetic_subfield_codes
branch
from
9a0d1b9
to
2287b76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derivation of the filing version assuming the first subfield in a field would hold content (e.g.,
$a) and thus failed when it held a pointer to a linking field (e.g.,$6 245-01). Now do checks and modification of the first alphabetic subfield.Fixed the code, added a test, changed CHANGES.md and upped the patch version.