-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ISO 639-3 language codes #293
Conversation
Looks good, thanks for being so complete! How do we know there are no conflicts between three-letter codes from LC MARC language codes vs ISO 639-3? Now and forever, even if ISO adds more codes? Should anything in the generation task check to make sure there wasn't a conflict? (Or does it already and I missed it?). If there is a code used in both, whichever one ends up in the file last (ISO) will probably overwrite the earlier one. That is, if the same code exists in both, in the current layout of the file you'll prob get the ISO translation rather than the MARC one. |
I found some answer to my own question! "The Library of Congress is https://www.loc.gov/marc/languages/introduction.pdf
However...
Is it possible for the same code to exist in both with slightly different labels, or is that not done? If that does happen, this change might mean some people using the new translation map would get different labels than using the old one previous to this PR? Or am I misunderstanding? If so, is that a problem? |
I attempted to throw out any duplicate codes with this line: sandbergja@2f48bb7#diff-00faae62d158f145b9eb2fe759cfdd1119003521712b53b7e99af8f4a49349caR72 So the yaml file produced should only ever contain the same code once, with the label coming from the LoC data, rather than the ISO 639-3 data. |
Also, if it would be helpful, I could add some kind of regression test to confirm that the translation map doesn't contain duplicates, and that any label from LoC takes precedence. |
Closes #292
Includes a new rake task to regenerate the language translation map as needed.