Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Section substitution does not work together with factors that are not an environment #312

Closed
pytoxbot opened this issue Sep 17, 2016 · 3 comments
Closed

Section substitution does not work together with factors that are not an environment #312

pytoxbot opened this issue Sep 17, 2016 · 3 comments
Labels
area:configuration bug:normal affects many people or has quite an impact help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. level:hard rought estimate that this might be quite hard to implement

Comments

@pytoxbot
Copy link

Reproducing tox.ini:

#!ini

[tox]
envlist = pypy, coverage

[testenv]
deps =
    pypy,coverage: twisted

[testenv:coverage]
deps =
    {[testenv]deps}
    coverage

which attempts to tell pip to install a req called pypy,coverage: twisted when the coverage test environment is run with tox -e coverage.

(The pypy environment works fine).
@obestwalter obestwalter added the bug label Nov 3, 2016
@obestwalter obestwalter added area:configuration bug:normal affects many people or has quite an impact level:medium rought estimate that this might be neither easy nor hard to implement and removed bug labels Sep 4, 2017
@obestwalter
Copy link
Member

This looks like an ordering problem: the factors need to be resolved before the section substitution. I would like to say this might be easy to fix, but the code handling the configuration has been growing for a while without any refactorings and is sufficiently convoluted. Definitely fixable though.

@obestwalter obestwalter mentioned this issue Sep 4, 2017
Closed
@obestwalter
Copy link
Member

see #509 for more interesting details :)

@obestwalter obestwalter changed the title Merging / inlining test environment sections doesn't entirely interact well with conditional settings. Section substitution does not work together with factors that are not an environment Sep 4, 2017
@obestwalter obestwalter added level:hard rought estimate that this might be quite hard to implement and removed level:medium rought estimate that this might be neither easy nor hard to implement labels Sep 4, 2017
@gaborbernat gaborbernat added the help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. label May 2, 2019
@jayvdb
Copy link

jayvdb commented Oct 19, 2020

@pytoxbot, could you re-test.

I believe this was fixed in 3.5.3, very likely in #1058
@gaborbernat

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area:configuration bug:normal affects many people or has quite an impact help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. level:hard rought estimate that this might be quite hard to implement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jayvdb @obestwalter @gaborbernat @pytoxbot