Return injection fix #445
Merged
Return injection fix #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this @caffeinepills! This also needs a new test to cover the intended difference between the old behavior and the new behavior. |
caffeinepills
force-pushed
the
return_rst_fix
branch
from
a91f671
to
4c772ac
Compare
Add tests for prolog and epilog. Add test runs to run all tests with configs of both.
caffeinepills
force-pushed
the
return_rst_fix
branch
from
0a2638c
to
1fe6ed7
Compare
for more information, see https://pre-commit.ci
|
I added tests (might be overkill?) A single test for both epilog and prolog to make sure the replacement functionality still works. Also it will run all test functions 4 times:
Not sure if that's overkill or not, but I can remove whichever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #444 and #425
Ignore the rst_epilog/rst_prolog during parsing type hints like #436 did. This still keeps the replacement behavior.
I tried adjusting the parsing, but the XML node line counting, and the list of lines given are too intertwined without rewriting it completely.
test_sphinx_autodoc_typehintswas broken for me in Windows, so I have added an encoding kwarg for it to work.EDIT: Working on making tests pass... and adding them.