trace: Add default impls for Grpc #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests seem to be failing for some reason? Outside of the changes I made that is |
LucioFranco
force-pushed
the
lucio/grpc-defaults
branch
from
7617004
to
0b8bf25
Compare
|
I went ahead an ignored that test since it seems fixed on master, when we merge this branch back in we can enable it again. |
|
I don't know why the public crates thing is failing now.... |
|
I think this is caused by recent nightly changes. (I've published a pull request (davidpdrsn/cargo-public-api-crates#5) to fix this.) |
|
Thanks @tottoto for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some default impls to allow the
trace::ResponseBodyto implDefaultand satisfy tonic's requirements for using an interceptor.