Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not working on brave browser - error "Uncaught DOMException: Failed to read the 'localStorage'" #22

Closed
miguelmota opened this issue Aug 14, 2019 · 6 comments
Closed

Not working on brave browser - error "Uncaught DOMException: Failed to read the 'localStorage'" #22

miguelmota opened this issue Aug 14, 2019 · 6 comments
Labels
bug Something isn't working external dependency Issue is caused due to an external dependency torus-website Should be opened on torus-website repo

Comments

@miguelmota
Copy link

Screen Shot 2019-08-13 at 10 21 06 PM

The widget is not working with the brave shield enabled. Used brave Version 0.67

The same code in this issue was used if you want to reproduce the issue
@miguelmota
Copy link
Author

miguelmota commented Aug 14, 2019 •
edited

Upon further inspection, the issue occurs when 3rd party cookies are blocked Screen Shot 2019-08-13 at 10 30 15 PM

An improvement would be to catch the error and handle it gracefully in the sdk

@chaitanyapotti
Copy link
Member

Handled

@miguelmota
Copy link
Author

@chaitanyapotti the error is still happening with latest torus version 0.0.26 on Brave

3vr6zyE9jl

@chaitanyapotti
Copy link
Member

Looks like a web3 issue.
This PR merge would resolve it

@chaitanyapotti chaitanyapotti mentioned this issue Aug 16, 2019
Closed
@chaitanyapotti chaitanyapotti added bug Something isn't working torus-website Should be opened on torus-website repo external dependency Issue is caused due to an external dependency labels Aug 18, 2019
@chaitanyapotti
Copy link
Member

chaitanyapotti commented Sep 12, 2019 •
edited

Looks like the PR is merged.
Awaiting web3 1.2.2 release

@chaitanyapotti
Copy link
Member

Released v0.2.0 which fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working external dependency Issue is caused due to an external dependency torus-website Should be opened on torus-website repo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miguelmota @chaitanyapotti