Rename package to django_recaptcha
#317
Merged
+76
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Andrew-Chen-Wang, could I kindly ask you to review this change? |
Merged
koutoftimer
suggested changes
Nov 4, 2023
Andrew-Chen-Wang
previously approved these changes
Nov 4, 2023
To avoid conflicts with other libraries that use the same package name, like django-simple-captcha. Ref: #291
Stormheg
force-pushed
the
291-rename-package
branch
from
94dd000 to
df7f686
Compare
Andrew-Chen-Wang
approved these changes
Nov 7, 2023
koutoftimer
approved these changes
Nov 8, 2023
|
Thanks both! I'll continue with the v4 release once I have some free time on my hands. |
|
@Stormheg let me know if you need some help, I'd like this release happening ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid conflicts with other libraries that use the same package name, like django-simple-captcha.
See: #291
Thanks to @koutoftimer for the name suggestion.
Since we are expecting to make a v4 release soon containing breaking changes, why not include this breaking change too?
This is missing a changelog entry and upgrade considerations. I plan on adding that later when rebasing #312
I tested this change by installing my development version of django_recaptcha into a project using it and made the necessary namespace changes. No issues, I think I changed all references.