Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package to django_recaptcha #317

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Rename package to django_recaptcha #317

merged 1 commit into from
Nov 8, 2023

Conversation

Stormheg
Copy link
Contributor

@Stormheg Stormheg commented Nov 4, 2023

To avoid conflicts with other libraries that use the same package name, like django-simple-captcha.

See: #291

Thanks to @koutoftimer for the name suggestion.

Since we are expecting to make a v4 release soon containing breaking changes, why not include this breaking change too?

This is missing a changelog entry and upgrade considerations. I plan on adding that later when rebasing #312


I tested this change by installing my development version of django_recaptcha into a project using it and made the necessary namespace changes. No issues, I think I changed all references.

@Stormheg
Copy link
Contributor Author

Stormheg commented Nov 4, 2023

Hey @Andrew-Chen-Wang, could I kindly ask you to review this change?

@Stormheg Stormheg mentioned this pull request Nov 4, 2023
Copy link
Contributor

@koutoftimer koutoftimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finished proofreading. Little change in error message required.

To avoid conflicts with other libraries that use the same package name,
like django-simple-captcha.

Ref: #291
@Stormheg Stormheg merged commit 6385e21 into main Nov 8, 2023
@Stormheg Stormheg deleted the 291-rename-package branch November 8, 2023 09:30
@Stormheg
Copy link
Contributor Author

Stormheg commented Nov 8, 2023

Thanks both! I'll continue with the v4 release once I have some free time on my hands.

@koutoftimer
Copy link
Contributor

@Stormheg let me know if you need some help, I'd like this release happening ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants