V3 action Verification #310
Merged
+31
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
alexrobertson-muckrack
force-pushed
the
verification
branch
from
975fd06 to
dc6b88d
Compare
Stormheg
reviewed
Sep 29, 2023
There was a problem hiding this comment.
This is great, thanks so much @alexrobertson-muckrack
I've made a couple suggestion to make this even better.
Co-authored-by: Storm Heg <storm@stormheg.co>
Co-authored-by: Storm Heg <storm@stormheg.co>
If there is a captcha error there won't be an action set, meaning we will log a warning about a mismatched action and don't log the actual error code returned by ReCaptcha
for more information, see https://pre-commit.ci
Stormheg
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for verification of reCAPTCHA V3
actionparameter. Tokens passed to the backend will be validated to ensure theactionvalue matches that of theactionconfigured in the widget.