Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 action Verification #310

Merged
merged 12 commits into from
Sep 29, 2023

Conversation

alexrobertson-muckrack
Copy link
Contributor

@alexrobertson-muckrack alexrobertson-muckrack commented Sep 19, 2023

Adds support for verification of reCAPTCHA V3 action parameter. Tokens passed to the backend will be validated to ensure the action value matches that of the action configured in the widget.

@cbracco

This comment was marked as resolved.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@Stormheg Stormheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks so much @alexrobertson-muckrack

I've made a couple suggestion to make this even better.

Co-authored-by: Storm Heg <storm@stormheg.co>
Co-authored-by: Storm Heg <storm@stormheg.co>
If there is a captcha error there won't be an action set, meaning we will log a warning about a mismatched action and don't log the actual error code returned by ReCaptcha
Copy link
Contributor

@Stormheg Stormheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks so much!

@Stormheg Stormheg merged commit 2d61293 into django-recaptcha:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants