New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed list of Metrics to Stabilize #6546
Labels
A-tokio
Area: The main tokio crate
C-feature-request
Category: A feature request.
M-metrics
Module: tokio/runtime/metrics
Comments
rcoh
added
A-tokio
Area: The main tokio crate
C-feature-request
Category: A feature request.
labels
May 8, 2024
Please see #6114, which renames some metrics. |
👍🏻 , it renames |
As a start, do you want to submit a PR that stabilizes just the overall metrics interface and |
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 13, 2024
…ilization This PR also introduces a `metrics` feature. Refs: tokio-rs#6546
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 13, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. This PR also introduces a `metrics` feature. Refs: tokio-rs#6546
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 13, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 13, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 14, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 14, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 14, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 14, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 14, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 14, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 15, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 15, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
We'd love to see this stabilized, especially these metrics that are the most important for us:
|
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 16, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 16, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
rcoh
added a commit
to rcoh/tokio
that referenced
this issue
May 17, 2024
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-tokio
Area: The main tokio crate
C-feature-request
Category: A feature request.
M-metrics
Module: tokio/runtime/metrics
Is your feature request related to a problem? Please describe.
Given the impact, hassle, and perceived "risk" of compiling with
tokio_unstable
, I'd like to propose we stabilize some of the existing metrics.Describe the solution you'd like
Based on existing usage I've identified, propose the following metrics for stabilization. I've selected metrics that could plausibly include an actual alarm threshold.
Proposed Metrics for Stabilization
num_active_tasks
active_tasks_count: Used for ensuring that runtime is behaving as expected (e.g. no accidental spawn leakages). Suggested alarms: high-water mark, 0.high-water mark
Proposed longer term work:
injection_queue_metrics() -> QueueMetrics { ... }
for queues in the future.workers_overflow_count(&self) -> impl Iterator<Item=(usize, usize)>
tokio-runtime-monitor
crate that takes an opinionated stats of metrics to report and includes alarms. Perhaps this crate could publish directly tometrics.rs
? This crate would compile on stable Tokio.Appendix: All Metrics
Additional context
#4073
The text was updated successfully, but these errors were encountered: