Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: prevent using unhandled_panic option on multi-thread runtime #6410

Merged
merged 4 commits into from Mar 20, 2024

Conversation

maminrayej
Copy link
Member

This PR documents and enforces the fact that the unhandled_panic option is only implemented for the current thread runtime, since it has caused confusion before: #6222.

@maminrayej maminrayej added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime labels Mar 17, 2024
Copy link
Member

@mox692 mox692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until a multi-thread version of unhandled_panic is implemented, this behavior looks reasonable to me.

@Darksonn Darksonn merged commit d51f168 into tokio-rs:master Mar 20, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants