Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: add next_many and poll_next_many to StreamMap #6409

Merged
merged 10 commits into from
Mar 26, 2024
Merged

stream: add next_many and poll_next_many to StreamMap #6409

merged 10 commits into from
Mar 26, 2024
+378 −3

Conversation

maminrayej
Copy link
Member

Resolves #6367.

@maminrayej maminrayej added the A-tokio-stream Area: The tokio-stream crate label Mar 17, 2024
@maminrayej
fix minrust, clippy, docs
Loading
Loading status checks…
f7c1f2b
Darksonn
Darksonn reviewed Mar 18, 2024
View reviewed changes
@maminrayej
resolve comments
Loading
Loading status checks…
ccb4fca
@maminrayej
re-run ci

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
c56287d
@maminrayej
re-run ci

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
9251336
Darksonn
Darksonn reviewed Mar 23, 2024
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation is great. :)

@maminrayej
move the start index and fix docs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
7702da8
@maminrayej
Merge branch 'master' into add-recv-many-to-stream-map
Loading
Loading status checks…
f5d5cf7
@maminrayej @mox692
Update tokio-stream/src/stream_map.rs
Loading
Loading status checks…
d5f581c 
Co-authored-by: Motoyuki Kimura <moymoymox@gmail.com>
@maminrayej maminrayej requested a review from mox692 March 24, 2024 11:34
Darksonn
Darksonn reviewed Mar 24, 2024
View reviewed changes
@maminrayej
add test for looping around
Loading
Loading status checks…
69420f0
@maminrayej
remove comment about Waker
Loading
Loading status checks…
86f6488
@maminrayej maminrayej requested review from Darksonn and mox692 March 24, 2024 22:34
@maminrayej maminrayej changed the title stream: add recv_many and poll_recv_many to StreamMap stream: add next_many and poll_next_many to StreamMap Mar 26, 2024
@maminrayej maminrayej merged commit 4601c84 into tokio-rs:master Mar 26, 2024
75 checks passed
@Darksonn Darksonn mentioned this pull request Sep 5, 2024
Merged
@maminrayej maminrayej deleted the add-recv-many-to-stream-map branch January 18, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn

@mox692 mox692

Assignees
No one assigned
Labels
A-tokio-stream Area: The tokio-stream crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE_REQ] Add recv_many to StreamMap
3 participants
@maminrayej @Darksonn @mox692