Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: reduce iteration count in short_sleeps test #6052

Merged
merged 1 commit into from Oct 5, 2023
Merged

time: reduce iteration count in short_sleeps test #6052

merged 1 commit into from Oct 5, 2023

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Oct 5, 2023

We've had test failures due to this test being really slow. In the run below, CI later timed out while running some later tests:

        SLOW [> 60.000s] tokio::time_sleep short_sleeps
        SLOW [>120.000s] tokio::time_sleep short_sleeps
        PASS [ 147.928s] tokio::time_sleep short_sleeps
------------
     Summary [ 238.734s] 1186 tests run: 1186 passed (2 slow), 13 skipped

Reducing the number of iterations should help with this.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-time Module: tokio/time labels Oct 5, 2023
hds
hds approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely makes sense.

@Darksonn Darksonn enabled auto-merge (squash) October 5, 2023 21:41
@Darksonn Darksonn merged commit 8cd3383 into master Oct 5, 2023
70 checks passed
@Darksonn Darksonn deleted the alice/test-short-sleeps branch October 5, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

@hds hds hds approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-time Module: tokio/time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Darksonn @carllerche @hds