tokio: fix cache line size for RISC-V #5994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
R-loom-current-thread
Darksonn
reviewed
Sep 10, 2023
Darksonn
added
A-tokio
Icenowy
force-pushed
the
rv-cacheline-64b
branch
from
fbd2276
to
6cc50c3
Compare
|
Thanks. Please run rustfmt on the file. (You can't use |
Currently tokio uses cache line size data from Go, which is not sufficient at least for T-Head C910 cores. The RISC-V Profiles document defines a maximum 64 bytes cache line for RVA22U64 (although the maximum is 128 bytes for RVA20U64), and the Linux kernel currently assumes 64B cache line too. Change the cache line size used to 64 bytes to match Linux and RVA22U64. Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
Icenowy
force-pushed
the
rv-cacheline-64b
branch
from
6cc50c3
to
51fd4db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When reading the tokio source code, I realized it currently uses 32B cache line size for RISC-V, which seems to be not sufficient. (Go uses 32B too, but it's currently known to be too small, see [1])
[1] https://go-review.googlesource.com/c/go/+/526659
Solution
Removing all set cache line size of 32B for riscv*, and add reference from kernel that uses 64B cache line size.