Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io: AsyncFd minor tweaks #5932

Merged
merged 3 commits into from Aug 14, 2023
Merged

Conversation

folkertdev
Copy link
Contributor

Motivation

Fixing or documenting some things I found confusing

Solution

  • simplify the logic of try_io by only checking once whether the error is WouldBlock
  • document why AsyncFd uses an Option around its inner field.
  • remove some .into() calls (clearer this way, I think, but also reduced code bloat)

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-io Module: tokio/io labels Aug 14, 2023
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 82bef00 into tokio-rs:master Aug 14, 2023
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-io Module: tokio/io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants