Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to 2021 edition #5560

Closed
Darksonn opened this issue Mar 19, 2023 · 0 comments · Fixed by #5571
Closed

Upgrade to 2021 edition #5560

Darksonn opened this issue Mar 19, 2023 · 0 comments · Fixed by #5571
Labels
A-tokio-stream Area: The tokio-stream crate A-tokio-test Area: The tokio-test crate A-tokio-util Area: The tokio-util crate

Comments

@Darksonn
Copy link
Contributor

We upgraded to the 2021 edition in the main Tokio crate in #5559, but that PR doesn't update the edition for the other crates in this repository.

To close this issue, submit a PR that upgrades the edition of tokio-stream, tokio-util, and tokio-test. The PR should make use of the new features that the edition provides, e.g. it should remove imports of TryFrom since that trait is now in the prelude.

The tokio-macros crate will be handled separately together with the syn upgrade.
@Darksonn Darksonn added E-help-wanted Call for participation: Help is requested to fix this issue. E-easy Call for participation: Experience needed to fix: Easy / not much A-tokio-util Area: The tokio-util crate A-tokio-test Area: The tokio-test crate A-tokio-stream Area: The tokio-stream crate labels Mar 19, 2023
@tzx tzx mentioned this issue Mar 21, 2023
Merged
@Darksonn Darksonn removed E-help-wanted Call for participation: Help is requested to fix this issue. E-easy Call for participation: Experience needed to fix: Easy / not much labels Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio-stream Area: The tokio-stream crate A-tokio-test Area: The tokio-test crate A-tokio-util Area: The tokio-util crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update stream, util, test to 2021 edition tzx/tokio
1 participant
@Darksonn