Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for peek/peek_from for sockets (unix_socket_peek) #1418

Open
cssivision opened this issue Dec 10, 2020 · 4 comments
Open

Support for peek/peek_from for sockets (unix_socket_peek) #1418

cssivision opened this issue Dec 10, 2020 · 4 comments
Labels
unstable Depends on unstable Rust feature.

Comments

@cssivision
Copy link

missing peek/peek_from in UnixDatagram, which exist in standard library. I'm willing to fire a PR for this.
@Thomasdezeeuw
Copy link
Collaborator

This would be fine, but currently the API in standard library is unstable I see. Currently Mio wraps the std lib types, which could be a bit challenging. We don't really have a good story for additional API added after our minimum rust version, e.g. also see #977. Why we could introduce an "unstable" feature flag or something for this, any ideas?

@cssivision
Copy link
Author

It's fine to introduce those methods when they become stable. so, close the issue now.

@Thomasdezeeuw
Copy link
Collaborator

Let's keep the issue open so we can track it.

@Thomasdezeeuw Thomasdezeeuw reopened this Dec 11, 2020
@Thomasdezeeuw Thomasdezeeuw added this to the V0.8 milestone Jan 8, 2021
@lucacasonato lucacasonato mentioned this issue Jul 8, 2021
Open
@Thomasdezeeuw
Copy link
Collaborator

This depends on rust-lang/rust#76923.

@Thomasdezeeuw Thomasdezeeuw removed this from the V0.8 milestone Nov 6, 2021
@Thomasdezeeuw Thomasdezeeuw added the unstable Depends on unstable Rust feature. label Nov 13, 2021
@Thomasdezeeuw Thomasdezeeuw changed the title add peek/peek_from for UnixDatagram add peek/peek_from for UnixDatagram (unix_socket_peek) Dec 8, 2023
@Thomasdezeeuw Thomasdezeeuw changed the title add peek/peek_from for UnixDatagram (unix_socket_peek) Support for peek/peek_from for sockets (unix_socket_peek) Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unstable Depends on unstable Rust feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Thomasdezeeuw @cssivision