Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sub instead of offset #668

Merged
merged 1 commit into from Feb 6, 2024
Merged

Use sub instead of offset #668

merged 1 commit into from Feb 6, 2024

Conversation

braddunbar
Copy link
Contributor

We're always subtracting here, and we already have a usize, so sub seems like a more appropriate usage to me.

@braddunbar
Use sub instead of offset
91c9655 
We're always subtracting here, and we already have a usize, so `sub`
seems like a more appropriate usage to me.
carllerche
carllerche approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good change.

@carllerche carllerche merged commit 47e8305 into tokio-rs:master Feb 6, 2024
15 checks passed
@braddunbar braddunbar mentioned this pull request Mar 22, 2024
Merged
@braddunbar braddunbar deleted the ptr-sub branch March 24, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@braddunbar @carllerche