Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in CONTRIBUTING.md #2612

Merged
merged 2 commits into from Feb 25, 2024
Merged

fix typo in CONTRIBUTING.md #2612

merged 2 commits into from Feb 25, 2024

Conversation

mladedav
Copy link
Contributor

Motivation

There was an unclosed parenthesis in the CONTRIBUTING.md document.

Solution

I removed said parenthesis.

jplatte
jplatte reviewed Feb 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
jplatte
jplatte approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting!

@jplatte
Copy link
Member

jplatte commented Feb 21, 2024

I'll take care of the CI failure in a separate PR.

@mladedav
Copy link
Contributor Author

Thanks, I've noticed it started happening lately but I didn't track the duplicates in examples.

@jplatte
Copy link
Member

jplatte commented Feb 25, 2024

Can you rebase to fix the CI issue?

@mladedav
Copy link
Contributor Author

@jplatte Done

@jplatte jplatte merged commit b03f6c1 into tokio-rs:main Feb 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mladedav @jplatte