New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove h2 from dependencies when http2 feature is off #2605
Conversation
v 0.1.3 hyper-util changelog seems to further separation of http1 and http2, would it be wise to upgrade to this version ? |
Does axum even build on hyper-util 0.1.2 without enabling its "server-auto" feature? I believe this is only possible since hyper-util 0.1.3? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
built a project in http1 with this version, h2 is not pulled anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, and sorry for the delay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, could you add a changelog entry (might cause conflicts so rebase recommended) before I merge?
I've added the changelog entry |
Motivation
Closes #2386
h2
does not need to be a dependency when the featurehttp2
is not enabled.Solution
I've changed the features of
hyper-util
we depend on conditionally.cargo tree -i h2 --features default,macros,multipart,ws --edges no-dev
prints nothing so the dependency is not there anymore.