Fix running in Go workspace #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working with Go workspaces, `go list -m -json` will return multiple objects.
For example:
```json
{
"Path": "golang.org/x/example/hello",
"Main": true,
"Dir": "/build/example/hello",
"GoMod": "/build/example/hello/go.mod",
"GoVersion": "1.19"
}
{
"Path": "example.com/hello",
"Main": true,
"Dir": "/build/hello",
"GoMod": "/build/hello/go.mod",
"GoVersion": "1.21"
}
```
Ensure that the JSON decoding can handle this output by stream-decoding the JSON and returning the
first suitable module.
|
Good catch, thank you for the PR! |
Codecov Report
@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 88.06% 86.45% -1.61%
==========================================
Files 2 2
Lines 176 192 +16
==========================================
+ Hits 155 166 +11
- Misses 14 18 +4
- Partials 7 8 +1
|
|
I'm going to add some tests and then we can merge it. |
tmzane
approved these changes
Aug 16, 2023
|
Merged in v0.7.2 🎉 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with Go workspaces,
go list -m -jsonwill return multiple objects. For example:{ "Path": "golang.org/x/example/hello", "Main": true, "Dir": "/build/example/hello", "GoMod": "/build/example/hello/go.mod", "GoVersion": "1.19" } { "Path": "example.com/hello", "Main": true, "Dir": "/build/hello", "GoMod": "/build/hello/go.mod", "GoVersion": "1.21" }Ensure that the JSON decoding can handle this output by stream-decoding the JSON and returning the first suitable module.