Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chroma: update chroma-go functions to pass context #610

Merged
merged 4 commits into from
Feb 19, 2024
Merged

chroma: update chroma-go functions to pass context #610

merged 4 commits into from
Feb 19, 2024

Conversation

dddbliss
Copy link
Contributor

@dddbliss dddbliss commented Feb 10, 2024

Chroma: Update calls to support added context params on calls from chroma-go

This is a small change to support the addition of context params on chroma-go api. Those changes were merged on Jan 9. PR #20.

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@dddbliss
Copy link
Contributor Author

Hello @tmc, wanted to see if this could be reviewed in short order. I currently use chroma-go outside of langchaingo, which has caused a version dependency. Also, this change brings chroma-go and langchaingo in-line api wise.

@issmirnov
Copy link

I can confirm that this commit is safe and does indeed resolve the issue. Tested by adding the following directive in my go.mod:

replace github.com/tmc/langchaingo => github.com/dddbliss/langchaingo v0.1.5-0.20240210073700-9ac0e7441c4d

and then rebuilding and running my project.

@@ -165,7 +165,7 @@ func (s Store) RemoveCollection() error {
if s.client == nil || s.collection == nil {
return fmt.Errorf("%w: no collection", ErrRemoveCollection)
}
_, errDc := s.client.DeleteCollection(s.collection.Name)
_, errDc := s.client.DeleteCollection(context.Background(), s.collection.Name)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might more appropriately be a TODO as we might want to accept ctx in this method, but this is fine. Thanks.

Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmc tmc merged commit 1b64e10 into tmc:main Feb 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants