Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use integer division for canonicalization of signatures #358

Merged
merged 1 commit into from
Mar 13, 2025
Merged

use integer division for canonicalization of signatures #358

merged 1 commit into from
Mar 13, 2025
+37 −6

Conversation

tomato42
Copy link
Member

fixes #353

@tomato42
use integer division for canonicalization of signatures
Loading
Loading status checks…
b6d43c6 
fixes #353
@tomato42 tomato42 self-assigned this Mar 13, 2025
@tomato42 tomato42 requested a review from Milis85 March 13, 2025 10:26
@tomato42 tomato42 added the bug unintended behaviour in ecdsa code label Mar 13, 2025
Milis85
Milis85 approved these changes Mar 13, 2025
View reviewed changes
Copy link

@Milis85 Milis85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, approved

@tomato42
Copy link
Member Author

Look good to me, approved

Thank you!

@tomato42 tomato42 merged commit 3c5df06 into master Mar 13, 2025
48 checks passed
@tomato42 tomato42 deleted the high-s-values branch March 13, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milis85 Milis85

Assignees

@tomato42 tomato42

Labels
bug unintended behaviour in ecdsa code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some high "s" values in ECDSA signature not detected due to error in floating point arithmetic
2 participants
@tomato42 @Milis85