New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-duplicate the version numbers in the project #285
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #285 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 666 666
=========================================
Hits 666 666 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@kurtmckee Looking at the history of docs/conf.py, you probably noticed several attempts to achieve this, howver it failed at some time and so at some point I just gave up on this... |
Sorry, I cannot get this to work, please repost your PR based on current HEAD... |
Was there an error message that you were seeing, like a FileNotFound exception or some such? |
I double-checked, and I think this PR is based on current HEAD (the parent commit is 44a913d). Could you share more details about the way that it didn't work? For example, we may have a difference in Python implementations or versions, or invocations (like using I tested this by running Thanks for taking the time to review this! |
Probably my bad, sorry. I'll re-check ASAP. |
Sorry for the troubles, I seem to have somehow wrecked my setup on my secondary machine, and yesterday was kind of a long working day... |
I understand long work days well! Thanks for revisiting this! |
I observed that the documentation version needed a recent fixup (44a913d); this PR eliminates the possibility that the version numbers fall out of sync between the project and its documentation.