Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum permissions for ci.yml #263

Merged
merged 1 commit into from Mar 17, 2023
Merged

Set minimum permissions for ci.yml #263

merged 1 commit into from Mar 17, 2023

Conversation

gabibguti
Copy link
Contributor

Resolves #261

@gabibguti
Copy link
Contributor Author

@tkem The workflow runs for a set of python versions and some python versions are failing in my fork. May I ask you to run the workflow in this draft PR to see if it's happening here too?

@gabibguti
Copy link
Contributor Author

Thanks. I will take a look why is this hapenning.

@tkem
Copy link
Owner

tkem commented Mar 17, 2023

@gabibguti: Not your fault, apparently the most recent version of black would like to format things a bit differently.
I'll pin a working black version in the master branch ASAP, then you should be able to rebase without problems.

@gabibguti
Copy link
Contributor Author

@tkem Oh ok, thanks for identifying that! I'll wait to rebase then :)

@tkem
Copy link
Owner

tkem commented Mar 17, 2023

@gabibguti OK, please rebase now and you should be all set!

Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti gabibguti marked this pull request as ready for review March 17, 2023 22:08
@gabibguti
Copy link
Contributor Author

All good now!

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Merging #263 (291ff12) into master (4b0d565) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##            master      #263   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          666       666           
=========================================
  Hits           666       666           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tkem tkem merged commit 76e4024 into tkem:master Mar 17, 2023
@tkem
Copy link
Owner

tkem commented Mar 17, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[security] Set minimum permissions for workflows
3 participants