Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 210: Fast path hardening take 2 #215

Merged
merged 20 commits into from Mar 3, 2024
Merged

Conversation

tkaitchuck
Copy link
Owner

@tkaitchuck tkaitchuck commented Feb 29, 2024

Fixes #210
This reverts the basic fast path for u64 to be two folded multiplies.

Some ancillary changes are made to test code to improve testing.

tkaitchuck and others added 20 commits October 24, 2023 18:14
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
The following updates are performed:
* update actions/checkout to v4
* replace unmaintained actions-rs/toolchain by dtolnay/rust-toolchain
* replace unmaintained actions-rs/cargo by direct invocation of cargo
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
* Bump rust-version to 1.72.0

* Bump rust version in MSRC CI check
…197)

Increase the MSRV presubmit checks to include multiple architectures

Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Merge master into release 0.8 branch
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
* Strengthen fastpath for u64 hashes

---------
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
@tkaitchuck tkaitchuck merged commit 7778357 into master Mar 3, 2024
18 checks passed
@tkaitchuck tkaitchuck deleted the fast_path_hardening branch March 3, 2024 17:23
tkaitchuck added a commit that referenced this pull request Mar 3, 2024
* Reverts the basic fast path for u64 to be two folded multiplies.

Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RandomState has too many collisions in low order bits when hashing a u64
3 participants