Increase the MSRV presubmit checks to include multiple architectures #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
|
https://github.com/tkaitchuck/aHash/actions/runs/7449693417/job/20266892686?pr=197#step:5:1 Seems to imply it just installed 1.60 in addition to the master build already installed Maybe you need to change cargo check --target armv7-unknown-linux-gnueabihfTo explicitly mention the tool chain like cargo +1.60 check --target armv7-unknown-linux-gnueabihfFWIW we use cargo msrv to check this in datafusion |
|
It runs |
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
|
I added this, everything is still passing... |
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
|
It looks like it used to pass with 1.60 but then failed with 1.71 |
tkaitchuck
added a commit
that referenced
this pull request
Feb 11, 2024
…197) Increase the MSRV presubmit checks to include multiple architectures Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.