Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add Ruby 3.3, 3.4 - and trust setup-ruby to bundle install #132

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Feb 27, 2024

This PR extends the CI build matrix.

It also stops repeating bundle install, after setup-ruby has done its installation using cached Bundler gems.

@mjankowski
Copy link
Contributor

Add 3.4 as well?

@olleolleolle
Copy link
Contributor Author

Sure, but the job has not even run once, it needs being accepted by a maintainer.

@mjankowski
Copy link
Contributor

Indeed.

@olleolleolle olleolleolle changed the title CI: Add Ruby 3.3, trust setup-ruby to bundle install CI: Add Ruby 3.3, 3.4 - and trust setup-ruby to bundle install Jan 10, 2025
@nateberkopec
Copy link
Collaborator

Workflow needed to be changed to run on PR :)

@nateberkopec
Copy link
Collaborator

2.4 failing for unrelated reasons for this PR so I'll merge this.

@nateberkopec nateberkopec merged commit aa82cd9 into tj:master Jan 27, 2025
8 of 9 checks passed
@olleolleolle olleolleolle deleted the patch-1 branch January 30, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants