Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG for 11.1.0 #2025

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Oct 7, 2023

Preparing for a minor release. I have gone through the Pending Release label, and taken a look at branch difference too.

I usually update the version number too in PR, but would it be more convenient if I leave that for you at release time @abetomo so you can use (say) npm version minor and get the tagging done at the same time?

I noticed #1928 introduces a throw, so I think it would be better in a major version. I'll remove it from develop branch and add it to release/12.x. (#2026)

@shadowspawn shadowspawn marked this pull request as ready for review October 7, 2023 04:09
@abetomo
Copy link
Collaborator

abetomo commented Oct 7, 2023

Thanks.
I think it would be good to update the version number in the PR as it would be easier to understand the changes.

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@abetomo abetomo merged commit f1ae2db into tj:develop Oct 13, 2023
11 checks passed
@shadowspawn shadowspawn deleted the feature/prepare-for-11.1.0 branch October 13, 2023 01:31
@shadowspawn
Copy link
Collaborator Author

Released, woop! Thanks @abetomo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants