Fix factory functions with typescript whole module import

[shadowspawn]

Pull Request

A subtle problem with Commander exports got reported in #1974

Problem

The factory functions like createOption were not available using a TypeScript whole module import (import * as commander) when esModuleInterop: true.

Solution

Explicitly export the factory functions, rather than just rely on implicitly being available via global program. This is also consistent with eventual goal of dropping deprecated default export of global program.

Inspired by #1974. Lists @aweebit as co-author in commit comment.

## ChangeLog

• fix: global factory functions now available when using TypeScript whole module import (import * as commander)

NB: re-export reverted in #2014 due to problems!

[abetomo]

LGTM

[shadowspawn]

I did think it looked like a circular reference, but if it made TypeScript happy...

However, a little amusingly and annoyingly, TypeScript thinks it is circular too! (Apparently I didn't try the full tests before now.)

It was interesting learning about the issue and I am still happy the tests are improved, but planning to comment out the factory functions again. There is an easy work-around if anyone hits the issue, which is to import the factory function using a named import.

% npm run typescript-checkJS

> commander@11.0.0 typescript-checkJS
> tsc --allowJS --checkJS index.js lib/*.js --noEmit

index.js:37:1 - error TS2303: Circular definition of import alias 'createCommand'.

37 exports.createCommand = program.createCommand;
   ~~~~~~~~~~~~~~~~~~~~~

index.js:38:1 - error TS2303: Circular definition of import alias 'createArgument'.

38 exports.createArgument = program.createArgument;
   ~~~~~~~~~~~~~~~~~~~~~~

index.js:39:1 - error TS2303: Circular definition of import alias 'createOption'.

39 exports.createOption = program.createOption;
   ~~~~~~~~~~~~~~~~~~~~


Found 3 errors in the same file, starting at: index.js:37