Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .executableDir() return type #1965

Merged
merged 1 commit into from Aug 19, 2023
Merged

Fix .executableDir() return type #1965

merged 1 commit into from Aug 19, 2023

Conversation

aweebit
Copy link
Contributor

@aweebit aweebit commented Aug 13, 2023 •
edited

Problem

This is currently not covered in types:

const program = new Command();
console.log(program.executableDir()); // null

Solution

Add null to the return type of .executableDir().

ChangeLog

Fixed

  • return type of .executableDir()

Peer PRs

Changes are to be merged into…

@shadowspawn shadowspawn added the on hold Not a current focus due to dependencies on other PR or number of other PR label Aug 13, 2023
This was referenced Aug 13, 2023
Closed
Closed
shadowspawn
shadowspawn approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shadowspawn shadowspawn removed the on hold Not a current focus due to dependencies on other PR or number of other PR label Aug 17, 2023
abetomo
abetomo approved these changes Aug 19, 2023
View reviewed changes
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@abetomo abetomo merged commit 68a4276 into tj:develop Aug 19, 2023
11 checks passed
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Aug 22, 2023
@shadowspawn shadowspawn mentioned this pull request Oct 13, 2023
Merged
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Feb 3, 2024
@shadowspawn
Copy link
Collaborator

Release in Commander v12.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

@shadowspawn shadowspawn shadowspawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aweebit @shadowspawn @abetomo