Have help command call help directly for subcommands, when possible #1864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
The implementation of the help command like
my-util help foo
is a bit fragile. The implementation invokes the subcommand passingthis._helpLongFlag
. This can fail if:See: #1863 (help option disabled)
Solution
Call
.help()
directly for a known (non-external) subcommand. Just use the help flags as a fallback for external subcommands.This takes a little extra code, but I have never been happy about passing through the help flags so I think it is worth it.
ChangeLog