New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] gitignore excludes are not correctly reflected #657
Comments
Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience. |
@keneanung This has been resolved in the latest release. |
Thanks! I'm eagerly awaiting it to filter through to the changed-files action to solve my workflow issues 🎉 |
Hm, this still doesn't seem to work correctly. I re-tested the reproduction repository above (https://github.com/keneanung/glob-action-tests) with the latest release and I'm still getting errors:
|
@keneanung I found the bug and it should now be fully resolved as the previous change only accounts for excluded files that also existed in the .gitignore without the |
That seems to have resolved it. Thank you very much! |
Is there an existing issue for this?
Does this issue exist in the latest version?
Describe the bug?
When ignoring a directory using
.gitignore
files, but explicitly including certain files, the settings are not correctly reflected in the glob action. The excludes of the ignores are not picked up.To Reproduce
.gitignore
:files/**
!files/file.txt
What OS are you seeing the problem on?
ubuntu-latest or ubuntu-20.04
Expected behavior?
Have
files/file.txt
in the found files. Currently, it errors instead as it finds no files at all.Relevant log output
Anything else?
A minimal repro repository can be found at https://github.com/keneanung/glob-action-tests
Code of Conduct
The text was updated successfully, but these errors were encountered: