-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guidelines on how to use monorepo/submodules? #79
Comments
Hi! Yes, monorepo is not working because it copies files to a temp folder, meaning we lose information from git. Happy to review a PR, but it might be a deep rabbit hole. #43 is a good place to start the trail. I think we might need to add support for symlinks, and check in the monorepo project that the new files are properly linked. |
Thanks for the reply! Before digging into it, Material for MkDocs has a project plugin (which is currently only available for sponsors), see https://squidfunk.github.io/mkdocs-material/plugins/projects/ The project plugin will be available to the public by the sponsorware strategy and is compatible with Vanilla MkDocs as well. The monorepo plugin will probably be discontinued (see backstage/mkdocs-monorepo-plugin#106) Would be interesting to test compatibility with that. Do you have any infos on it? I think that would be my first step before I dig into the code. |
I have not looked into it. The sponsoring for mkdocs material would have to increase from 13k to 24k for it to become public though: https://squidfunk.github.io/mkdocs-material/insiders/#24000-blockpaprika I do wish that happens very soon, but it's unlikely. |
Author of Material for MkDocs here. The projects plugin does not make any assumptions about where your projects come from, so you could also put them into submodules and check them out before building it. Since the projects plugin will invoke local builds in the directory of where your submodules are located, this plugin should work without problems, as it does not use temporary directories. If it doesn't, please raise an issue with a minimal reproduction and we're happy to investigate. |
Thanks to both of you for your inputs! We will most probably switch fully to Material for MkDocs (thanks @squidfunk for the insight). I will report back here once I have evaluated the compatibility of the two. Feel free to close the issue @timvink and thanks again! |
Hello again, I was able to test it with the projects plugin from @squidfunk.
The mkdocs-dummyproject is registered as a submodule. When executing git status there, everything is committed. nav:
- Start: index.md
- MkDocs Configuration: mkdocs.md
- Test: project://mkdocs-dummyproject A local build and serve with PWD in the submodule works perfectly. |
Thanks for testing! This is likely related to the projects plugin, but we need a minimal reproduction to know for sure. If you can craft something that we can easily run on our machines, please create a complete bug report. |
Thanks for the input @squidfunk. I will create a complete bug report with reproducible example next week. |
Hi again @squidfunk Here you go squidfunk/mkdocs-material#6970 Thanks a lot! |
I'm setting up MkDocs with the monorepo plugin. I got all up and running except for git-authors, where the Authors from the submodules are not displayed.
Are there any guidelines on how to use the plugin with submodules, or the monorepo in particular? If not, would you be open to add this feature? If yes, I'd also be open to contribute it.
The text was updated successfully, but these errors were encountered: