Remove generics on error types. #75
Merged
+313
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `FsLoader` to allow multiples IRIs bound to the same path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the error types in
json-ldcurrently needs to be provided with the loader error type as generic parameter. Dealing with generic type parameters on error types is really annoying, as it propagates everywhere. This PR fixes this erasing the loader error type using aLoaderErrortrait allowing the different algorithm to transform a loader error into an IRI (causing the error) and an error message. I believe this will be enough in the majority of cases to give enough info about the error while reducing the burden propagating type generics.This decision was made while fixing the
FsLoaderto allow multiples IRIs bound to the same path, to allow easy debugging. For this reason this PR also includes a fix for theFsLoader.