{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":119459915,"defaultBranch":"master","name":"pandas","ownerLogin":"timhoffm","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2018-01-30T00:29:42.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/2836374?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1696442128.0","currentOid":""},"activityList":{"items":[{"before":"a62913fa74343b9dc0fdb3ad9ba937ea479d91fc","after":null,"ref":"refs/heads/attrs-deepcopy","pushedAt":"2023-10-04T17:55:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"timhoffm","name":"Tim Hoffmann","path":"/timhoffm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2836374?s=80&v=4"}},{"before":"fcde0aaf7dfc5e6e8e4c04ab2283d20061cff63e","after":"a62913fa74343b9dc0fdb3ad9ba937ea479d91fc","ref":"refs/heads/attrs-deepcopy","pushedAt":"2023-10-04T08:25:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"timhoffm","name":"Tim Hoffmann","path":"/timhoffm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2836374?s=80&v=4"},"commit":{"message":"ENH: propagating attrs always uses deepcopy\n\nAlways using a deepcopy prevents shared state and thus unintentional\nmodification of the attrs of other objects. IMHO this safety has a\nhigher priority than the slight performance cost of the deepcopy.\nThe implementation now skips the copying if *attrs* are not used (i.e.\nan empty dict). This check takes only ~20ns. Thus, the attrs propagation\nmechanism has no performance impact if attrs are not used.\n\nCloses #54134.","shortMessageHtmlLink":"ENH: propagating attrs always uses deepcopy"}},{"before":"554a764d52fbc6436b19261f9276a137c13ae723","after":"fcde0aaf7dfc5e6e8e4c04ab2283d20061cff63e","ref":"refs/heads/attrs-deepcopy","pushedAt":"2023-10-04T07:42:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"timhoffm","name":"Tim Hoffmann","path":"/timhoffm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2836374?s=80&v=4"},"commit":{"message":"ENH: propagating attrs always uses deepcopy\n\nAlways using a deepcopy prevents shared state and thus unintentional\nmodification of the attrs of other objects. IMHO this safety has a\nhigher priority than the slight performance cost of the deepcopy.\nThe implementation now skips the copying if *attrs* are not used (i.e.\nan empty dict). This check takes only ~20ns. Thus, the attrs propagation\nmechanism has no performance impact if attrs are not used.\n\nCloses #54134.","shortMessageHtmlLink":"ENH: propagating attrs always uses deepcopy"}},{"before":"33667a0e8a44707e5748b72e9064e6a954c4741d","after":"554a764d52fbc6436b19261f9276a137c13ae723","ref":"refs/heads/attrs-deepcopy","pushedAt":"2023-10-02T09:22:44.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"timhoffm","name":"Tim Hoffmann","path":"/timhoffm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2836374?s=80&v=4"},"commit":{"message":"ENH: propagating attrs always uses deepcopy\n\nAlways using a deepcopy prevents shared state and thus unintentional\nmodification of the attrs of other objects. IMHO this safety has a\nhigher priority than the slight performance cost of the deepcopy.\nThe implementation now skips the copying if *attrs* are not used (i.e.\nan empty dict). This check takes only ~20ns. Thus, the attrs propagation\nmechanism has no performance impact if attrs are not used.\n\nCloses #54134.","shortMessageHtmlLink":"ENH: propagating attrs always uses deepcopy"}},{"before":"cb34da566085a161dcdb1a8cdeab41666bc5cf49","after":"33667a0e8a44707e5748b72e9064e6a954c4741d","ref":"refs/heads/attrs-deepcopy","pushedAt":"2023-09-30T09:34:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"timhoffm","name":"Tim Hoffmann","path":"/timhoffm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2836374?s=80&v=4"},"commit":{"message":"ENH: propagating attrs always uses deepcopy\n\nAlways using a deepcopy prevents shared state and thus unintentional\nmodification of the attrs of other objects. IMHO this safety has a\nhigher priority than the slight performance cost of the deepcopy.\nThe implementation now skips the copying if *attrs* are not used (i.e.\nan empty dict). This check takes only ~20ns. Thus, the attrs propagation\nmechanism has no performance impact if attrs are not used.\n\nCloses #54134.","shortMessageHtmlLink":"ENH: propagating attrs always uses deepcopy"}},{"before":"eae4787701478aaceb62d136f88326f02e0cf9ad","after":"cb34da566085a161dcdb1a8cdeab41666bc5cf49","ref":"refs/heads/attrs-deepcopy","pushedAt":"2023-09-28T10:15:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"timhoffm","name":"Tim Hoffmann","path":"/timhoffm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2836374?s=80&v=4"},"commit":{"message":"ENH: propagating attrs always uses deepcopy\n\nAlways using a deepcopy prevents shared state and thus unintentional\nmodification of the attrs of other objects. IMHO this safety has a\nhigher priority than the slight performance cost of the deepcopy.\nThe implementation now skips the copying if *attrs* are not used (i.e.\nan empty dict). This check takes only ~20ns. Thus, the attrs propagation\nmechanism has no performance impact if attrs are not used.\n\nCloses #54134.","shortMessageHtmlLink":"ENH: propagating attrs always uses deepcopy"}},{"before":"c51678dac34af50263bc9fb6f18ca88c08a15e78","after":"eae4787701478aaceb62d136f88326f02e0cf9ad","ref":"refs/heads/attrs-deepcopy","pushedAt":"2023-09-28T10:13:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"timhoffm","name":"Tim Hoffmann","path":"/timhoffm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2836374?s=80&v=4"},"commit":{"message":"ENH: propagating attrs always uses deepcopy\n\nAlways using a deepcopy prevents shared state and thus unintentional\nmodification of the attrs of other objects. IMHO this safety has a\nhigher priority than the slight performance cost of the deepcopy.\nThe implementation now skips the copying if *attrs* are not used (i.e.\nan empty dict). This check takes only ~20ns. Thus, the attrs propagation\nmechanism has no performance impact if attrs are not used.\n\nCloses #54134.","shortMessageHtmlLink":"ENH: propagating attrs always uses deepcopy"}},{"before":"99d67a5e43a6db61849456c45217e52c63dc4a04","after":"c51678dac34af50263bc9fb6f18ca88c08a15e78","ref":"refs/heads/attrs-deepcopy","pushedAt":"2023-09-28T10:07:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"timhoffm","name":"Tim Hoffmann","path":"/timhoffm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2836374?s=80&v=4"},"commit":{"message":"ENH: propagating attrs always uses deepcopy\n\nAlways using a deepcopy prevents shared state and thus unintentional\nmodification of the attrs of other objects. IMHO this safety has a\nhigher priority than the slight performance cost of the deepcopy.\nThe implementation now skips the copying if *attrs* are not used (i.e.\nan empty dict). This check takes only ~20ns. Thus, the attrs propagation\nmechanism has no performance impact if attrs are not used.\n\nCloses #54134.","shortMessageHtmlLink":"ENH: propagating attrs always uses deepcopy"}},{"before":null,"after":"99d67a5e43a6db61849456c45217e52c63dc4a04","ref":"refs/heads/attrs-deepcopy","pushedAt":"2023-09-28T10:01:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"timhoffm","name":"Tim Hoffmann","path":"/timhoffm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2836374?s=80&v=4"},"commit":{"message":"ENH: propagating attrs always uses deepcopy\n\nAlways using a deepcopy prevents shared state and thus unintentional\nmodification of the attrs of other objects. IMHO this safety has a\nhigher priority than the slight performance cost of the deepcopy.\nThe implementation now skips the copying if *attrs* are not used (i.e.\nan empty dict). This check takes only ~20ns. Thus, the attrs propagation\nmechanism has no performance impact if attrs are not used.\n\nCloses #54134.","shortMessageHtmlLink":"ENH: propagating attrs always uses deepcopy"}},{"before":"7abba3877b977ab84a3cd86dabf29ccfe2e20887","after":null,"ref":"refs/heads/attrs-property","pushedAt":"2023-08-02T16:03:11.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"timhoffm","name":"Tim Hoffmann","path":"/timhoffm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2836374?s=80&v=4"}},{"before":"21eec4f2129cefe4c2dd574d3153aac257da6f0e","after":"7abba3877b977ab84a3cd86dabf29ccfe2e20887","ref":"refs/heads/attrs-property","pushedAt":"2023-08-01T23:48:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"timhoffm","name":"Tim Hoffmann","path":"/timhoffm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2836374?s=80&v=4"},"commit":{"message":"CLN: Remove None check in attrs property lookup\n\n`self._attrs` is always initialized to an empty dict per\nhttps://github.com/pandas-dev/pandas/blob/c93e8034a13d3dbe2358b1b2f868a0d54d1034a7/pandas/core/generic.py#L275\n\nThe attribute `_attrs` is only witten to in two other places\n\na) in the attrs.setter property (which enforces dict as well)\nb) in __setstate__, which takes whatever the state is:\n   https://github.com/pandas-dev/pandas/blob/c93e8034a13d3dbe2358b1b2f868a0d54d1034a7/pandas/core/generic.py#L2129C24-L2129C24\n   AFAICS (including code history) I do not see a reason that this could be None.\n   But if we want to be very defensive, we should do the dict enforcing here.","shortMessageHtmlLink":"CLN: Remove None check in attrs property lookup"}},{"before":"d87c0723047bbc2192ec8706c04a9e8732c282a5","after":"21eec4f2129cefe4c2dd574d3153aac257da6f0e","ref":"refs/heads/attrs-property","pushedAt":"2023-08-01T23:47:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"timhoffm","name":"Tim Hoffmann","path":"/timhoffm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2836374?s=80&v=4"},"commit":{"message":"CLN: Remove None check in attrs property lookup\n\n`self._attrs` is always initialized to an empty dict per\nhttps://github.com/pandas-dev/pandas/blob/c93e8034a13d3dbe2358b1b2f868a0d54d1034a7/pandas/core/generic.py#L275\n\nThe attribute `_attrs` is only witten to in two other places\n\na) in the attrs.setter property (which enforces dict as well)\nb) in __setstate__, which takes whatever the state is:\n   https://github.com/pandas-dev/pandas/blob/c93e8034a13d3dbe2358b1b2f868a0d54d1034a7/pandas/core/generic.py#L2129C24-L2129C24\n   AFAICS (including code history) I do not see a reason that this could be None.\n   But if we want to be very defensive, we should do the dict enforcing here.","shortMessageHtmlLink":"CLN: Remove None check in attrs property lookup"}},{"before":null,"after":"d87c0723047bbc2192ec8706c04a9e8732c282a5","ref":"refs/heads/attrs-property","pushedAt":"2023-08-01T21:18:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"timhoffm","name":"Tim Hoffmann","path":"/timhoffm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2836374?s=80&v=4"},"commit":{"message":"CLN: Remove None check in attrs property lookup\n\n`self._attrs` is always initialized to an empty dict per\nhttps://github.com/pandas-dev/pandas/blob/c93e8034a13d3dbe2358b1b2f868a0d54d1034a7/pandas/core/generic.py#L275\n\nThe attribute `_attrs` is only witten to in two other places\n\na) in the attrs.setter property (which enforces dict as well)\nb) in __setstate__, which takes whatever the state is:\n   https://github.com/pandas-dev/pandas/blob/c93e8034a13d3dbe2358b1b2f868a0d54d1034a7/pandas/core/generic.py#L2129C24-L2129C24\n   AFAICS (including code history) I do not see a reason that this could be None.\n   But if we want to be very defensive, we should do the dict enforcing here.","shortMessageHtmlLink":"CLN: Remove None check in attrs property lookup"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADj35ltwA","startCursor":null,"endCursor":null}},"title":"Activity · timhoffm/pandas"}