- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Use in memory database for testing SQL in docs #1223
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1223 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 540 540
Lines 13969 13952 -17
=========================================
- Hits 13969 13952 -17
☔ View full report in Codecov by Sentry. |
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
📝 Docs preview for commit 010c79e at: https://611d964aa5127c2596f97561--fastapi.netlify.app |
I think this would be helpful to merge, or at least to have as a side note. I've wasted a while trying to get an in-memory database working for tests, only to find this and realise that I was missing |
📝 Docs preview for commit a608d9c at: https://631e1417f19e9b4d81e04ac7--fastapi.netlify.app |
📝 Docs preview for commit 7b88da9 at: https://639cc814c1ba730cfd259b2e--fastapi.netlify.app |
I don't know whether this will be merged (seems to be open still?), but it has helped me. It saves a lot of clean up during and after tests. |
📝 Docs preview for commit d56574f at: https://645157b86dc7d82ca6b38e85--fastapi.netlify.app |
@tiangolo would you like to merge? |
Thanks @HarshaLaxman! 🚀 I've been wanting to update the docs about SQL to use SQLModel and re-use a bunch of those docs there. But for now, I'll take this. 🤓 And thanks everyone else for the comments and for letting me know that this is useful to you! 🍰 |
Useful for me, maybe it is better as just a note?