Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Fix Pydantic method name in docs/en/docs/advanced/path-operation-advanced-configuration.md #10826

Merged

Conversation

ahmedabdou14
Copy link
Contributor

@ahmedabdou14 ahmedabdou14 commented Dec 23, 2023

Fixing small typo of pydantic v2 json schema method

image

Should be Item.model_json_schema instead

Doc path

@tiangolo
Copy link
Owner

📝 Docs preview for commit 09bfcab at: https://5a392e13.fastapitiangolo.pages.dev

Copy link
Contributor

@hasansezertasan hasansezertasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alejsdev alejsdev changed the title Fix Pydantic method name in path operation advanced configuration ✏️ Fix Pydantic method name in docs/en/docs/advanced/path-operation-advanced-configuration.md Jan 13, 2024
@alejsdev alejsdev merged commit 1caee0f into tiangolo:master Jan 13, 2024
35 checks passed
@alejsdev
Copy link
Collaborator

Nice! Thank you @ahmedabdou14 🥳

And thanks for the review @hasansezertasan 🪄

@alejsdev alejsdev added the docs Documentation about how to use FastAPI label Jan 13, 2024
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants